Skip to content

Follow-up PR/fix for #438, exclude nvidia targets in other find command #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

Follow-up PR/fix for #438, exclude nvidia targets in other find command #440

merged 1 commit into from
Apr 25, 2025

Conversation

bedroge
Copy link
Collaborator

@bedroge bedroge commented Apr 25, 2025 •
edited
Loading

Overlooked that nvidia should have been excluded in the other find command in #438. It does find aarch64/nvidia/* now, but without this fix it will also still find aarch64/nvidia itself.

# without the fix from this PR:
$ find ${EESSI_TOPDIR}/software/linux/*/* -maxdepth 0 \( ! -name 'intel' -a ! -name 'amd' \) -type d
/cvmfs/software.eessi.io/versions/2023.06/software/linux/aarch64/a64fx
/cvmfs/software.eessi.io/versions/2023.06/software/linux/aarch64/generic
/cvmfs/software.eessi.io/versions/2023.06/software/linux/aarch64/neoverse_n1
/cvmfs/software.eessi.io/versions/2023.06/software/linux/aarch64/neoverse_v1
/cvmfs/software.eessi.io/versions/2023.06/software/linux/aarch64/nvidia
/cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/generic

# with the fix
$ find ${EESSI_TOPDIR}/software/linux/*/* -maxdepth 0 \( ! -name 'intel' -a ! -name 'amd' -a ! -name 'nvidia' \) -type d
/cvmfs/software.eessi.io/versions/2023.06/software/linux/aarch64/a64fx
/cvmfs/software.eessi.io/versions/2023.06/software/linux/aarch64/generic
/cvmfs/software.eessi.io/versions/2023.06/software/linux/aarch64/neoverse_n1
/cvmfs/software.eessi.io/versions/2023.06/software/linux/aarch64/neoverse_v1
/cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/generic

@ocaisa ocaisa merged commit ab86099 into EESSI:main Apr 25, 2025
3 checks passed
@bedroge bedroge deleted the find_grace_target branch April 25, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bedroge @ocaisa